Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Configure finder for friendsofphp/php-cs-fixer #1291

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

localheinz
Copy link
Contributor

This pull request

  • configures the finder for friendsofphp/php-cs-fixer

Running

vendor/bin/php-cs-fixer fix

on current master yields

Loaded config default from "/Users/am/Sites/stripe/stripe-php/.php-cs-fixer.php".
Using cache file ".php-cs-fixer.cache".

In Finder.php line 611:

  You must call one of in() or append() methods before iterating over a Finder.


fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--format FORMAT] [--stop-on-violation] [--show-progress SHOW-PROGRESS] [--] [<path>...]

@CLAassistant
Copy link

CLAassistant commented May 22, 2022

CLA assistant check
All committers have signed the CLA.

@szepeviktor
Copy link
Contributor

This PR may need #1292 as the dot is removed.

@localheinz
Copy link
Contributor Author

@richardm-stripe

Looks like the workflow needs an approval, can you do that, please?

@szepeviktor
Copy link
Contributor

Coveralls said Couldn't find a repository matching this job

@localheinz
Copy link
Contributor Author

localheinz commented Oct 17, 2022

@szepeviktor

See https://github.com/stripe/stripe-php/actions/runs/3267022039/jobs/5371671598#step:11:8, as well as .github/workflows/ci.yml:

COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}

The COVERALLS_REPO_TOKEN secret is - of course - not available for pushes triggered by outside collaborators.

@richardm-stripe
Copy link
Contributor

I'm going to ignore coveralls and debug that separately. This PR shouldn't affect test coverage.

@richardm-stripe
Copy link
Contributor

Thank you for the contribution @localheinz!

@richardm-stripe richardm-stripe merged commit 5096bca into stripe:master Oct 17, 2022
@localheinz localheinz deleted the fix/finder branch October 17, 2022 17:16
@localheinz
Copy link
Contributor Author

Thank you, @richardm-stripe!

I do not know whether coveralls supports token-less upload of code-coverage reports.

I do know that token-less upload works well with https://codecov.io.

Similar to https://github.com/coverallsapp/github-action, codecov offers an action for uploading code coverage reports, see https://github.com/codecov/codecov-action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants