Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate property from Subscription #812

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Remove duplicate property from Subscription #812

merged 1 commit into from
Nov 27, 2019

Conversation

baijunyao
Copy link
Contributor

$pending_setup_intent is duplicated.

  1. stripe-php/lib/Subscription.php

    Line 34 in ff089fd

    * @property string|null $pending_setup_intent

  2. stripe-php/lib/Subscription.php

    Line 43 in ff089fd

    * @property string $pending_setup_intent

$schedule is duplicated and can only be string or null, It's not a SubscriptionSchedule object.

  1. stripe-php/lib/Subscription.php

    Line 37 in ff089fd

    * @property string|null $schedule

  2. stripe-php/lib/Subscription.php

    Line 44 in ff089fd

    * @property \Stripe\SubscriptionSchedule $schedule

remi-stripe
remi-stripe approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix!

@remi-stripe remi-stripe merged commit 2f5f11d into stripe:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baijunyao @remi-stripe @stripe-ci