improve consistency between HTTP clients

This commit modifies `PycurlClient` to set the `should_retry` attribute of `APIConnectionError` exceptions, like `RequestsClient` does.
stripe · Aug 12, 2019 · aba93a6 · aba93a6
1 parent ccef833
commit aba93a6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/stripe/http_client.py b/stripe/http_client.py
@@ -494,21 +494,24 @@ def _handle_request_error(self, e):
                 "https://twitter.com/stripestatus, or let us know at "
                 "support@stripe.com."
             )
+            should_retry = True
         elif e.args[0] in [pycurl.E_SSL_CACERT, pycurl.E_SSL_PEER_CERTIFICATE]:
             msg = (
                 "Could not verify Stripe's SSL certificate.  Please make "
                 "sure that your network is not intercepting certificates.  "
                 "If this problem persists, let us know at "
                 "support@stripe.com."
             )
+            should_retry = False
         else:
             msg = (
                 "Unexpected error communicating with Stripe. If this "
                 "problem persists, let us know at support@stripe.com."
             )
+            should_retry = False
 
         msg = textwrap.fill(msg) + "\n\n(Network error: " + e.args[1] + ")"
-        raise error.APIConnectionError(msg)
+        raise error.APIConnectionError(msg, should_retry=should_retry)
 
     def _get_proxy(self, url):
         if self._proxy: