Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types for CRUDL methods on parents #1032

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Types for CRUDL methods on parents #1032

merged 7 commits into from
Aug 31, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Aug 30, 2023 •
edited
Loading

Add a type parameter to APIResource and related classes, and set that as the return type of

  • APIResource.retrieve
  • CreateableAPIResource.create
  • DeleteableAPIResource.delete
  • ListableAPIResource.list
  • SingletonAPIResource.retrieve
  • UpdateableAPIResource.modify

@richardm-stripe richardm-stripe force-pushed the richardm-generic-apiresource-parents branch from ca7154c to a9c0458 Compare August 30, 2023 22:49
@richardm-stripe richardm-stripe marked this pull request as ready for review August 30, 2023 22:57
pakrym-stripe
pakrym-stripe requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor Qs and nits.

richardm-stripe and others added 2 commits August 30, 2023 16:25
@richardm-stripe
Add back bound
c0f8ccd
@richardm-stripe @pakrym-stripe
Apply suggestions from code review
6425a00 
Co-authored-by: pakrym-stripe <99349468+pakrym-stripe@users.noreply.github.com>
@richardm-stripe richardm-stripe mentioned this pull request Aug 31, 2023
Merged
pakrym-stripe
pakrym-stripe requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more occurrences of bound="StripeObject"

@richardm-stripe richardm-stripe enabled auto-merge (squash) August 31, 2023 16:53
@richardm-stripe richardm-stripe merged commit 51faa13 into master Aug 31, 2023
@richardm-stripe richardm-stripe deleted the richardm-generic-apiresource-parents branch August 31, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-stripe pakrym-stripe pakrym-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @pakrym-stripe