Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: ExpandableField #1044

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Types: ExpandableField #1044

merged 3 commits into from
Sep 6, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Sep 5, 2023 •
edited
Loading

More precise types for "ExpandableField" resource properties. Commit-by-commit:

  1. In Expandable field I define an alias ExpandableField[T] = Union[T, str].
  2. In ExpandableField I generate the annotations that use it.
  3. In Manual TransferReversal -> Reversal I manually fix an issue in the generated code that should be solved by generator changes for Types: ListObject #1043
  4. Deduped imports Dedupe imports

@richardm-stripe richardm-stripe changed the title Expandable field type Types: ExpandableField Sep 5, 2023
@richardm-stripe richardm-stripe force-pushed the richardm-expandable-field-type branch from 5d11320 to 1c5707b Compare September 5, 2023 23:56
@richardm-stripe richardm-stripe requested review from a team and pakrym-stripe and removed request for a team September 6, 2023 00:33
@richardm-stripe richardm-stripe merged commit fca51fc into master Sep 6, 2023
@richardm-stripe richardm-stripe deleted the richardm-expandable-field-type branch September 6, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-stripe pakrym-stripe pakrym-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @pakrym-stripe