Track usage of deprecated save
#1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-usage
branch
3 times, most recently
from
b3d9149 to
55aac4d
Compare
anniel-stripe
approved these changes
Dec 1, 2023
richardm-stripe
force-pushed
the
richardm-usage
branch
from
62f5394 to
3200dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: not to be merged until after #1142 so as to minimize merge conflicts.
Changelog
.saveinX-Stripe-Client-Telemetry. (You can disable telemetry viastripe.enable_telemetry = false, see the README.)Details
The unsatisfying thing about the implementation is how the telemetry header is added at the
http_clientlayer of abstraction. I would have liked to change this and moved it toapi_requestor-- but we are planning to fundamentally upheave api_requestor in the near future anyway, so I chose not to.I added
_usageas an optional keyword param toApiRequestor.requestandHttpClient.request_with_retries(along with streaming analogs, and to internal methods).Testing
I modified the existing test case for telemetry (in integration_test.py) to use a method that would trigger "save" usage to be included.