Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api_base from RequestOptions type #1184

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

anniel-stripe
Copy link
Contributor

api_base never worked as a request option. If passed in as a keyword argument to a method, it would get treated as a request parameter. Removing as this option is misleading and unsupported.

@anniel-stripe anniel-stripe enabled auto-merge (squash) December 21, 2023 22:03
@anniel-stripe anniel-stripe merged commit a4369f8 into master Dec 21, 2023
14 checks passed
@xavdid-stripe xavdid-stripe deleted the anniel-remove-api-base-option branch May 10, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants