Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper to add beta version #1259

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add helper to add beta version #1259

merged 3 commits into from
Feb 28, 2024

Conversation

helenye-stripe
Copy link
Contributor

@helenye-stripe helenye-stripe commented Feb 27, 2024

along with #1260

Curious whether you think I should make a new test file as well.

@richardm-stripe
Copy link
Contributor

This works for me! The APIRequestor test is fine and it feels right this test would be next to the test for setAppInfo. Would also be open to a stripe_test.py or something, but it would get irritating to have that only in beta but not in master.

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs format

@helenye-stripe helenye-stripe enabled auto-merge (squash) February 28, 2024 20:18
@helenye-stripe helenye-stripe merged commit 4d92790 into beta Feb 28, 2024
14 checks passed
@xavdid-stripe xavdid-stripe deleted the helenye-beta-helper branch May 10, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants