Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain exceptions when reraising them #1366

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Jul 19, 2024

This makes debugging easier, since the original exception's details and traceback aren't just flattened to a string.

Copy link

@OscarMj1 OscarMj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akx akx force-pushed the exception-reasons branch from cc0fb59 to 3e8aa0f Compare July 29, 2024 07:02
@xavdid-stripe xavdid-stripe requested review from OscarMj1 and removed request for OscarMj1 August 19, 2024 18:49
This makes debugging easier, since the original exception's details and traceback aren't just flattened to a string
@akx akx force-pushed the exception-reasons branch from 3e8aa0f to a971189 Compare August 26, 2024 09:32
@akx
Copy link
Contributor Author

akx commented Aug 26, 2024

Rebased. Cc @xavdid-stripe (I don't think the currently assigned reviewer is associated with Stripe?)

@xavdid-stripe
Copy link
Member

looks great, thank you!

@xavdid-stripe xavdid-stripe merged commit 86c9f23 into stripe:master Aug 26, 2024
15 checks passed
@akx akx deleted the exception-reasons branch August 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants