Minor fixes #362
Merged
Minor fixes #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,4 +6,4 @@ | |||
|
|
|||
| class InvoiceItem(CreateableAPIResource, UpdateableAPIResource, | |||
| ListableAPIResource, DeletableAPIResource): | |||
| OBJECT_NAME = 'invoice_item' | |||
| OBJECT_NAME = 'invoiceitem' | |||
There was a problem hiding this comment.
We should probably cut a new version for this or something to prevent many future instances of confusion around this bad naming ...
|
Thanks for following up with these OB! Am I good to release these changes as a patch version? (i.e. the interface of |
|
Yep, the interface is identical. |
|
Awesome. Thanks! |
|
Released as 1.71.2. |
This was referenced Oct 31, 2017
This was referenced Nov 7, 2017
This was referenced Nov 29, 2017
This was referenced Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
A few random fixes:
removed the existing
modify_external_accountandmodify_sourceclass methods onAccountandCustomerresp. since those methods are now created by the@nested_resource_class_methodsdecorator (Nested resource class methods #350)fixed the object name for
InvoiceItemand addedBalanceTransactioninutil.convert_to_stripe_object. I think I broke both of these in Split resource.py #351 :/The existing
@nested_resource_class_methodstests ensure the removed methods still actually exist. Added a very basic test to avoid regression for the other fixes.