Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disputes are not createable #368

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries @remi-stripe

This was noticed by @remi-stripe while working on tests. The Dispute resource was declared as createable, however that is not the case. The test was passing because the request was not being sent to the API.

@remi-stripe
Copy link
Contributor

remi-stripe commented Nov 7, 2017

@ob-stripe why not ignore since we're going to merge stripe-mock in a few days?
ignore me this is about the resource itself

@brandur-stripe
Copy link
Contributor

Nice catch.

Hm, technically this is breaking, but I think I'm going to ship this as a minor release anyway given that this API was never really usable ...

@brandur-stripe brandur-stripe merged commit 41783c1 into master Nov 7, 2017
@brandur-stripe brandur-stripe deleted the ob-cant-create-disputes branch November 7, 2017 19:50
@brandur-stripe
Copy link
Contributor

Released as 1.74.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants