Start building universal wheels #397
Conversation
| @@ -1,6 +1,6 @@ | |||
| The MIT License | |||
|
|
|||
| Copyright (c) 2010-2011 Stripe (http://stripe.com) | |||
| Copyright (c) 2010-2018 Stripe (http://stripe.com) | |||
There was a problem hiding this comment.
This one hadn't been updated in a while ;)
There was a problem hiding this comment.
lol. Maybe another seven years until the next time too ...
| @@ -0,0 +1,5 @@ | |||
| [bdist_wheel] | |||
| universal = 1 | |||
There was a problem hiding this comment.
This enables the build of universal wheels by default. Cf. https://packaging.python.org/tutorials/distributing-packages/#universal-wheels
| universal = 1 | ||
|
|
||
| [metadata] | ||
| license_file = LICENSE |
There was a problem hiding this comment.
This is to ensure the license file is included in the wheel files. Cf. https://wheel.readthedocs.io/en/stable/#including-the-license-in-the-generated-wheel-file.
setup.py
Outdated
| from version import VERSION | ||
| about = {} | ||
| with open(os.path.join('stripe', 'version.py')) as f: | ||
| exec(f.read(), about) |
There was a problem hiding this comment.
This is slightly cleaner than manipulating the sys path, and removes a flake8 warning about imports needing to be grouped at the top of the file. (Note that setup.py is not automatically validated by flake8 currently.)
There was a problem hiding this comment.
Kind of a nit again, but could change about to something a little more descriptive like version_contents?
Love the same though. The old code is tremendously opaque by comparison.
|
|
ob-stripe
changed the title
|
@brandur-stripe PTAL |
|
Minor comment above, but LGTM. Having very recently ran into a problem with a package missing from one particular Python version and failing my whole build, this is a pretty exciting change. Thanks OB! |
ob-stripe
force-pushed
the
ob-universal-wheel
branch
from
e143b69 to
aa5c968
Compare
r? @brandur-stripe
cc @stripe/api-libraries
Since we no longer use
2to3and the library can now directly be used by Python 2 or 3, we also no longer need to build distinct wheels.This PR enables the flag to start building universal wheels by default, as well as add a few opportunistic fixes to the
setup.pyand license files.