Handle the case where both error messages are None and request ids are None. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e None. stripe#196 fixed this TypeError for when request_id is set and message is None, but it didn't handle the case where both were None.
|
LGTM (and thanks for the test). |
|
And just out of curiosity: did you run into a came where a request ID actually was |
|
Released as 1.82.1. |
|
Wow, thanks for the quick merge and release! This was a very synthetic issue: we were constructing an StripeError via |
|
No worries!
Okay, thanks! I just wanted to make sure that nothing unexpected was going on with the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#196 fixed this TypeError for
when request_id is set and message is None, but it didn't handle the
case where both were None.