Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where both error messages are None and request ids are None. #430

Merged
merged 1 commit into from
May 14, 2018

Conversation

jfly
Copy link
Contributor

@jfly jfly commented May 14, 2018

#196 fixed this TypeError for
when request_id is set and message is None, but it didn't handle the
case where both were None.

…e None.

stripe#196 fixed this TypeError for
when request_id is set and message is None, but it didn't handle the
case where both were None.
@brandur-stripe
Copy link
Contributor

LGTM (and thanks for the test).

@brandur-stripe brandur-stripe merged commit 76b2b95 into stripe:master May 14, 2018
@brandur-stripe
Copy link
Contributor

And just out of curiosity: did you run into a came where a request ID actually was None in production, or is this more for testing synthetic errors?

@brandur-stripe
Copy link
Contributor

Released as 1.82.1.

@jfly
Copy link
Contributor Author

jfly commented May 14, 2018

Wow, thanks for the quick merge and release!

This was a very synthetic issue: we were constructing an StripeError via StripeError(), and then running into this TypeError.

@jfly jfly deleted the fix-typeerror-with-none branch May 14, 2018 20:18
@brandur-stripe
Copy link
Contributor

No worries!

This was a very synthetic issue: we were constructing an StripeError via StripeError(), and then running into this TypeError.

Okay, thanks! I just wanted to make sure that nothing unexpected was going on with the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants