Adds 'partner_id' property to set_app_info hash #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zach wick <zwick@stripe.com>
ob-stripe
approved these changes
Jun 28, 2018
|
Released in 1.83.0. |
|
I'm just realizing that if someone uses @brandur-stripe wdyt? Should we reorder the params? |
|
@ob-stripe @brandur-stripe There was some discussion that the arguments should be in alphabetical order, but I'm open to instead adding |
Ah, good point. I'd probably just leave it as this point ... realistically the use of this feature in Python is probably still pretty minimal, and the use that we recommend in the README uses named parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for an optional partner_id attribute in the SetAppInfo hash.