Fix setup.py #445
Merged
Fix setup.py #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Jul 10, 2018
|
|
||
| with open(path.join(here, 'LONG_DESCRIPTION.rst'), encoding='utf-8') as f: | ||
| os.chdir(here) |
There was a problem hiding this comment.
This is the actual fix.
ob-stripe
commented
Jul 10, 2018
| exec(f.read(), version_contents) | ||
|
|
||
| tests_require = [ |
There was a problem hiding this comment.
This was just a remainder after merging the integration-v2 branch.
ob-stripe
commented
Jul 10, 2018
| @@ -75,6 +72,7 @@ def run_tests(self): | |||
| "Programming Language :: Python :: 3.4", | |||
| "Programming Language :: Python :: 3.5", | |||
| "Programming Language :: Python :: 3.6", | |||
| "Programming Language :: Python :: 3.7", | |||
There was a problem hiding this comment.
Opportunistically added that we support Python 3.7 which was recently released.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Fixes
setup.pyso that it can be run from any directory (which is what our release tooling does).Fixes #444.