Add support for ScheduledQueryRun #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Jul 26, 2018
|
|
||
|
|
||
| class ScheduledQueryRun(ListableAPIResource): | ||
| OBJECT_NAME = 'scheduled_query_run' |
There was a problem hiding this comment.
The object name should really be sigma.scheduled_query_run based on recent API decisions we made. It's not though, similarly to apple pay domains.
The issue is that if we change this in the future, we'll need to have some custom logic for the deserializer which will be tricky. I don't think we have renamed an object before.
This comment is mostly here as food for thoughts though!
remi-stripe
force-pushed
the
remi-add-scheduled-query-run
branch
from
bb6adb8 to
f779ac7
Compare
remi-stripe
force-pushed
the
remi-add-scheduled-query-run
branch
from
f779ac7 to
451e2c5
Compare
ob-stripe
approved these changes
Jul 27, 2018
|
Released as 2.3.0. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries
This fixes #454