Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings for Terminal endpoints #478

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Bindings for Terminal endpoints #478

merged 3 commits into from
Sep 24, 2018

Conversation

daz-stripe
Copy link
Contributor

Bindings for Terminal endpoints

  • Connection Tokens
  • Locations
  • Readers

ob-stripe
ob-stripe suggested changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of linting issues, and you need to import the new terminal module here so that stripe.terminal is accessible.

stripe/api_resources/terminal/reader.py Outdated


class Reader(CreateableAPIResource, ListableAPIResource,
UpdateableAPIResource):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

stripe/api_resources/terminal/location.py Outdated


class Location(CreateableAPIResource, ListableAPIResource,
UpdateableAPIResource):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to align this line with CreatableAPIResource to satisfy the linter.

@stripe-ci stripe-ci assigned daz-stripe and unassigned ob-stripe Sep 18, 2018
@jd-stripe jd-stripe force-pushed the daz-terminal-bindings branch from fbbfa99 to e0df99c Compare September 18, 2018 17:00
@daz-stripe daz-stripe assigned ob-stripe and unassigned daz-stripe Sep 18, 2018
ob-stripe
ob-stripe approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass after stripe-mock update.

@stripe-ci stripe-ci assigned daz-stripe and unassigned ob-stripe Sep 19, 2018
@daz-stripe daz-stripe force-pushed the daz-terminal-bindings branch from b52bac2 to 8281b0d Compare September 24, 2018 20:37
@brandur-stripe
Copy link
Contributor

LGTM!

@brandur-stripe brandur-stripe merged commit 32dafb2 into master Sep 24, 2018
@brandur-stripe brandur-stripe deleted the daz-terminal-bindings branch September 24, 2018 22:10
@brandur-stripe
Copy link
Contributor

Released as 2.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

@jd-stripe jd-stripe Awaiting requested review from jd-stripe

@rattrayalex-stripe rattrayalex-stripe Awaiting requested review from rattrayalex-stripe

Assignees

@ob-stripe ob-stripe

@brandur-stripe brandur-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daz-stripe @brandur-stripe @ob-stripe @stripe-ci @jd-stripe