-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pipenv with poetry #561
Conversation
Well, that was fast! I don't have a great feeling for which dependency manager would be best, but this seems plausible.
SG. |
Just a note that pipenv is still broken and still hasn't released any new version since last year, but poetry fixed the issue. The build is now green on Travis without any changes to the PR. I'm still not 100% sold on switching to Poetry, but at the very least the project seems more active. |
Looks good to me if you want to try it! |
Okay, I've spent some time comparing the source distribution and wheel file built by We'll need to upgrade our internal tooling to update the version number inside Just in case you have final thoughts before I merge this: ptal @brandur-stripe |
Go for it OB. |
Alright, going to merge this and attempt a release. |
Released as 2.29.2 \o/ |
This PR gets rid of both
setup.py
and pipenv, and uses Poetry to both manage dependencies and build the library.Unfortunately, at the moment it looks like Poetry suffers from the same issue as pipenv: when setting up the development environment, it tries to install the
stripe
library in editable mode, which doesn't work with recent versions of pip.I'm still not sure that Poetry will work better for us than pipenv did. For now I think we should just wait a few more weeks to see if Poetry fixes this issue.