Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what max_network_retries does #606

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

Changaco
Copy link
Contributor

It's not limited to network errors, it also triggers a retry when a 409 HTTP response is returned by the API.

@brandur-stripe
Copy link
Contributor

Thanks @Changaco!

Can you:

  1. Replace the word "intermittent" in the first paragraph with "transient". I think this is more apt in describing things like 409s as well.
  2. Let's just remove that second paragraph. I think it'd be better not to be too specific here so that we have more flexibility in updating the implementation without changing the README. A future change for example might be to detect a lock timeout and retry on that as well.
  3. Squash when it's all together.

@Changaco
Copy link
Contributor Author

@brandur-stripe I would rather not drop the second paragraph that this PR was made to add, so I reworded it instead. Let me know if it's still not good enough.

@brandur-stripe
Copy link
Contributor

Okay that works.

@brandur-stripe brandur-stripe merged commit bddaa33 into stripe:master Aug 14, 2019
@Changaco Changaco deleted the patch-2 branch August 14, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants