Add support for header parameters in ListObject request methods
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
approved these changes
Sep 10, 2019
|
Released as 2.36.0. |
|
I think this is the cause of #611 ? |
This was referenced Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
ListObjectprovides three instance methods for issuing API requests on the list:create,retrieveandlist.Previously none of these supported "special" parameters for headers:
api_key,stripe_account,stripe_version, andidempotency_key(forcreateonly as the other two are GET requests). This PR fixes that.The code is very much not DRY, but it's consistent with the rest of the library. The requestor layer in stripe-python is starting to show its age, we should refactor it at some point.
Fixes #609.