Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for header parameters in ListObject request methods #610

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Sep 9, 2019

r? @brandur-stripe
cc @stripe/api-libraries

ListObject provides three instance methods for issuing API requests on the list: create, retrieve and list.

Previously none of these supported "special" parameters for headers: api_key, stripe_account, stripe_version, and idempotency_key (for create only as the other two are GET requests). This PR fixes that.

The code is very much not DRY, but it's consistent with the rest of the library. The requestor layer in stripe-python is starting to show its age, we should refactor it at some point.

Fixes #609.

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, it's a little non-DRY, but doesn't seem too bad to me :)

Thanks for the fix!

LGTM.

@ob-stripe ob-stripe merged commit 431154f into master Sep 10, 2019
@ob-stripe ob-stripe deleted the ob-fix-609 branch September 10, 2019 18:02
@ob-stripe
Copy link
Contributor Author

Released as 2.36.0.

@therefromhere
Copy link

I think this is the cause of #611 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested retrieve doesn't accept stripe_account
4 participants