Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorObject to StripeError exceptions #619

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Add ErrorObject to StripeError exceptions #619

merged 1 commit into from
Sep 26, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Similar to stripe/stripe-ruby#811 and stripe/stripe-php#705.

@ob-stripe
Copy link
Contributor Author

Ugh there's a circular import issue. Will fix.

stripe/api_resources/error_object.py Show resolved Hide resolved
stripe/error.py Show resolved Hide resolved
@ob-stripe
Copy link
Contributor Author

Circular import should be fixed, ptal @remi-stripe.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments but LGTM

z.update(y)
return z


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that not a helper function in Python already 🙀

assert err.error is not None
assert err.error.code == "some_error"
assert err.error.charge is None

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding tests for all 7 params in case we break something?

@ob-stripe ob-stripe merged commit 8f47023 into master Sep 26, 2019
@ob-stripe ob-stripe deleted the ob-error branch September 26, 2019 17:05
@ob-stripe
Copy link
Contributor Author

Released as 2.37.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants