Add support for reverse pagination #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-improve-list
branch
from
51148c9 to
dc24b3e
Compare
ob-stripe
force-pushed
the
ob-improve-list
branch
from
dc24b3e to
cbbd565
Compare
brandur-stripe
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Arg, sorry about the delay here OB! It came in right as I was leaving for a few weeks, and I didn't quite get to it in time.
Thanks for the proactive work on this one, and keeping the implementation very similar to Ruby's so that we don't need to understand two different implementations! Looks great.
|
Released as 2.38.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Add support for backwards auto-pagination, and generally improves
ListObject's code by making it closer to the Ruby / PHP implementations.Fixes #585.