Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploading files with Unicode names (Python 2.7) #636

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Fix uploading files with Unicode names (Python 2.7) #636

merged 1 commit into from
Dec 31, 2019

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Dec 30, 2019

It resulted in UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128) before

ob-stripe
ob-stripe approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ob-stripe ob-stripe merged commit 47552da into stripe:master Dec 31, 2019
@ob-stripe
Copy link
Contributor

Released as 2.41.1.

@illia-v illia-v deleted the unicode-file-names branch December 31, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illia-v @ob-stripe @stripe-ci