Set daemon attribute instead of using setDaemon method that was deprecated in Python 3.10 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated in Python 3.10
|
|
|
Ü |
|
Looks good. Since python 2.7 is the lowest target of this package, this should be safe to merge (supported since 2.6) |
dcr-stripe
approved these changes
May 19, 2022
There was a problem hiding this comment.
Thanks for the contribution here @tirkarthi and apologies for the extremely long delay.
This looks good. CI is passing and https://docs.python.org/2/library/threading.html confirms we can do this as of 2.6 + that setDaemon is the pre-2.6 API. Merging and this will go out with the next release.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 8, 2022
## 3.5.0 - 2022-06-30 * [#831](stripe/stripe-python#831) API Updates * Add support for `deliver_card`, `fail_card`, `return_card`, and `ship_card` test helper methods on resource `Issuing.Card` * Switch from using `instance_url` to computing method path in place for custom methods. * Switch from using explicit class methods for test helpers instead of using meta-programming. ## 3.4.0 - 2022-06-17 * [#824](stripe/stripe-python#824) API Updates * Add support for `fund_cash_balance` test helper method on resource `Customer` * [#823](stripe/stripe-python#823) Trigger workflows on beta branches ## 3.3.0 - 2022-06-08 * [#818](stripe/stripe-python#818) fix: Update cash balance methods to no longer require nested ID. ## 3.2.0 - 2022-05-23 * [#812](stripe/stripe-python#812) API Updates * Add support for new resource `Apps.Secret` ## 3.1.0 - 2022-05-19 * [#810](stripe/stripe-python#810) API Updates * Add support for new resources `Treasury.CreditReversal`, `Treasury.DebitReversal`, `Treasury.FinancialAccountFeatures`, `Treasury.FinancialAccount`, `Treasury.FlowDetails`, `Treasury.InboundTransfer`, `Treasury.OutboundPayment`, `Treasury.OutboundTransfer`, `Treasury.ReceivedCredit`, `Treasury.ReceivedDebit`, `Treasury.TransactionEntry`, and `Treasury.Transaction` * Add support for `retrieve_payment_method` method on resource `Customer` * Add support for `list_owners` and `list` methods on resource `FinancialConnections.Account` * [#719](stripe/stripe-python#719) Set daemon attribute instead of using setDaemon method that was deprecated in Python 3.10 * [#767](stripe/stripe-python#767) Bump vendored six to 1.16.0 * [#806](stripe/stripe-python#806) Start testing on pypy-3.8 * [#811](stripe/stripe-python#811) Add sanitize_id method ## 3.0.0 - 2022-05-09 * [#809](stripe/stripe-python#809) Release of major version v3.0.0. The [migration guide](https://github.com/stripe/stripe-python/wiki/Migration-Guide-for-v3) contains more information. (⚠️ = breaking changes): *⚠️ Replace the legacy `Order` API with the new `Order` API. * New methods: `cancel`, `list_line_items`, `reopen`, and `submit` * Removed methods: `pay` and `return_order` * Removed resources: `OrderItem` and `OrderReturn` *⚠️ Rename `financial_connections.account.refresh` to `financial_connections.refresh_account` * Add support for `amount_discount`, `amount_tax`, and `product` on `LineItem` ## 2.76.0 - 2022-05-05 * [#808](stripe/stripe-python#808) API Updates * Add support for new resources `FinancialConnections.AccountOwner`, `FinancialConnections.AccountOwnership`, `FinancialConnections.Account`, and `FinancialConnections.Session` ## 2.75.0 - 2022-05-03 * [#805](stripe/stripe-python#805) API Updates * Add support for new resource `CashBalance`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718