Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify metadata deletion message. #754

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Clarify metadata deletion message. #754

merged 1 commit into from
Dec 9, 2021

Conversation

dcr-stripe
Copy link
Contributor

r? @richardm-stripe

Summary

Clarifies the message when we try to mutate a metadata value to '' directly on a StripeObject.

  • When using save(), = None should be used instead to delete.
  • When using modify(), users should pass in '' to delete.

Motivation

#753

This will hopefully clear up some clarification for the above issue when mixing paradigms.

@dcr-stripe dcr-stripe merged commit 053f1a2 into master Dec 9, 2021
@dcr-stripe dcr-stripe deleted the dcr-del branch December 9, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants