Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same python base version for fmt and lint #814

Merged
merged 1 commit into from
May 24, 2022
Merged

Use the same python base version for fmt and lint #814

merged 1 commit into from
May 24, 2022

Conversation

pakrym-stripe
Copy link
Contributor

So we can select one global version and it works for everything.

dcr-stripe
dcr-stripe approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This works for me as long as we continue testing for 2.7 in CI.

@pakrym-stripe pakrym-stripe merged commit 97ee54f into master May 24, 2022
@remi-stripe remi-stripe deleted the pakrym/Use_the_same_python_base_version_for_fmt_and_lint branch September 28, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcr-stripe dcr-stripe dcr-stripe approved these changes

Assignees

@pakrym-stripe pakrym-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pakrym-stripe @dcr-stripe