Next major release changes #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # stripe/api_resources/credit_note.py # stripe/api_resources/invoice.py # stripe/api_resources/source.py
dcr-stripe
approved these changes
Aug 1, 2022
Irostovsky
reviewed
Nov 20, 2024
| @@ -9,17 +9,16 @@ class UpdateableAPIResource(APIResource): | |||
| @classmethod | |||
| def modify(cls, sid, **params): | |||
| url = "%s/%s" % (cls.class_url(), quote_plus(util.utf8(sid))) | |||
| return cls._static_request("post", url, **params) | |||
There was a problem hiding this comment.
Sorry, what is the purpose of removing api_key support from the modify method?
How could I call modify without passing api_key explicitly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
4.0.0 - 2022-08-01
Breaking changes that arose during code generation of the library that we postponed for the next major version. For changes to the SDK, read more detailed description at https://github.com/stripe/stripe-python/wiki/Migration-guide-for-v4. For changes to the Stripe products, read more at https://stripe.com/docs/upgrades#2022-08-01.
"⚠️ " symbol highlights breaking changes.
AlipayAccount,BitcoinReceiver,BitcoinTransaction,IssuerFraudRecord,Recipient,RecipientTransfer, andThreeDSecureclasses.Charge.update_disputeandCharge.close_disputemethods that were using legacy REST API endpoint. Prefer Dispute.modify and Dispute.closeCard.detailsmethod andCardDetailsresource. The REST API endpoint is not longer supported.Source.source_transactionsmethod. PreferSubscriptionItem.list_source_transactionsSubscriptionItem.usage_record_summariesmethod. PreferSubscriptionItem.list_usage_record_summariesCharge.refundmethod. Prefer Refund.createApplicationFee.refundreturns an instance ofApplicationFeeand doesn't mutate the instance ofApplicationFee.Customer.delete_discountno longer resets thediscountproperty toNoneand returns the deleted discount instead. If you were relying on this behavior, reset the discount property manually:LineItemresource now inherits fromStripeObjectas it has no methods of it's own.Subscription.delete_discountreturns an instance of deleted discount and doesn't mutate the instance ofSubscription.