Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxxo payment #139

Merged
merged 8 commits into from
Apr 6, 2021
Merged

Oxxo payment #139

merged 8 commits into from
Apr 6, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

resolves #27

@arekkubaczkowski arekkubaczkowski changed the title Oxxo payment WIP: Oxxo payment Mar 31, 2021
@thorsten-stripe
Copy link
Contributor

@bg-stripe @michelleb-stripe @mshafrir-stripe I’m having some issues with OXXO on Android:

  1. the next action type enum in the Android SDK is display_oxxo_details (https://github.com/stripe/stripe-android/blob/master/stripe/src/main/java/com/stripe/android/model/StripeIntent.kt#L63) however in the API it is oxxo_dislay_details (https://stripe.com/docs/api/payment_intents/object#payment_intent_object-next_action-oxxo_display_details). Not sure if this is a recent change. I’d be happy to open a PR on stripe-android android, but there is another issue:
  2. The iOS SDK automatically displays the hosted_voucher_url in the webview and when closing the webview maps the requires_action status to a succeeded handler status (https://github.com/stripe/stripe-ios/blob/master/Stripe/STPPaymentHandler.swift#L1197-L1205). While the docs claim that the Android SDK does the same (https://stripe.com/docs/payments/oxxo/accept-a-payment#android-submit-payment) that’s actually not true, and instead comes back with StripeIntent.Status.RequiresAction in stripe.onPaymentResult. Is that intentional? Are folks meant to display the voucher themselves? But if so, the behavior differs from the stripe-ios. Any idea what to do here?

@thorsten-stripe thorsten-stripe changed the title WIP: Oxxo payment Oxxo payment Apr 6, 2021
@thorsten-stripe
Copy link
Contributor

Android issue fixed here: stripe/stripe-android#3559

@thorsten-stripe thorsten-stripe merged commit 43090b2 into master Apr 6, 2021
@thorsten-stripe thorsten-stripe deleted the feat/oxxo-payment branch April 6, 2021 07:46
arekkubaczkowski pushed a commit that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OXXO
2 participants