Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment UI #74

Merged
merged 51 commits into from
Apr 9, 2021
Merged

Payment UI #74

merged 51 commits into from
Apr 9, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

@arekkubaczkowski arekkubaczkowski commented Feb 17, 2021

resolves #1

@thorsten-stripe
Copy link
Contributor

In the example app I hit the following errors:

  • iOS Payments UI Basic Integration (custom integration works fine)
    image

  • Android
    image

Anything I can do to resolve this? Or should I wait because it's not yet ready for review?

@arekkubaczkowski
Copy link
Collaborator Author

@thorsten-stripe unfortunately there are API difference between ios and android and I had to made a change which broke down ios. I will fix it to make it testable on iOS but the whole PR is not ready for review yet.

@arekkubaczkowski
Copy link
Collaborator Author

@thorsten-stripe It's fixed already but note that it works on iOS only for now.

docs/payments-ui.md Outdated Show resolved Hide resolved
@thorsten-stripe thorsten-stripe linked an issue Apr 7, 2021 that may be closed by this pull request
@thorsten-stripe thorsten-stripe changed the base branch from master to payment-sheet April 8, 2021 04:40
ios/StripeSdk.swift Outdated Show resolved Hide resolved
@thorsten-stripe
Copy link
Contributor

thorsten-stripe commented Apr 8, 2021

All AIs from #1 (comment) have been completed except for

beta-2 branch is planned to be released by EOD tmr. At that point I will update it and then merge this PR into payment-sheet branch.

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge this onto payment-sheet branch 👍

@thorsten-stripe thorsten-stripe merged commit ff4e3b2 into payment-sheet Apr 9, 2021
@thorsten-stripe thorsten-stripe deleted the feat/payment-ui-bindings branch April 9, 2021 10:26
@thorsten-stripe thorsten-stripe changed the title WIP: Payment UI Payment UI Apr 9, 2021
arekkubaczkowski added a commit that referenced this pull request Apr 22, 2021
* chore: examples styling

* chore: remove 3rd party input

Co-authored-by: Arkadiusz Kubaczkowski <arek.kubaczkowski@callstak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Pay configuration to Payment Sheet Add Payments UI bindings (Payment Sheet)
3 participants