Add request headers field to RequestEventEnd

stripe · Jan 5, 2023 · 8715d6c · 8715d6c
1 parent e14b364
commit 8715d6c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/lib/stripe/instrumentation.rb b/lib/stripe/instrumentation.rb
@@ -34,6 +34,7 @@ class RequestEndEvent
       attr_reader :path
       attr_reader :request_id
       attr_reader :response
+      attr_reader :request_header
       attr_reader :request_body
 
       # Arbitrary user-provided data in the form of a Ruby hash that's passed
@@ -43,7 +44,7 @@ class RequestEndEvent
       attr_reader :user_data
 
       def initialize(duration:, http_status:, method:, num_retries:, path:,
-                     request_id:, user_data: nil, response: nil, request_body: nil)
+                     request_id:, user_data: nil, response: nil, request_header: nil, request_body: nil)
         @duration = duration
         @http_status = http_status
         @method = method
@@ -52,6 +53,7 @@ def initialize(duration:, http_status:, method:, num_retries:, path:,
         @request_id = request_id
         @user_data = user_data
         @response = response
+        @request_header = request_header
         @request_body = request_body
         freeze
       end

diff --git a/lib/stripe/stripe_client.rb b/lib/stripe/stripe_client.rb
@@ -494,7 +494,7 @@ def self.maybe_gc_connection_managers
           end
         end
 
-      http_resp = execute_request_with_rescues(method, api_base, context) do
+      http_resp = execute_request_with_rescues(method, api_base, headers, context) do
         self.class
             .default_connection_manager(config)
             .execute_request(method, url,
@@ -564,7 +564,7 @@ def self.maybe_gc_connection_managers
       http_status >= 400
     end
 
-    private def execute_request_with_rescues(method, api_base, context)
+    private def execute_request_with_rescues(method, api_base, headers, context)
       num_retries = 0
 
       begin
@@ -587,7 +587,7 @@ def self.maybe_gc_connection_managers
 
         log_response(context, request_start, http_status, resp.body, resp)
         notify_request_end(context, request_duration, http_status,
-                           num_retries, user_data, resp)
+                           num_retries, user_data, resp, headers)
 
         if config.enable_telemetry? && context.request_id
           request_duration_ms = (request_duration * 1000).to_i
@@ -614,7 +614,7 @@ def self.maybe_gc_connection_managers
           log_response_error(error_context, request_start, e)
         end
         notify_request_end(context, request_duration, http_status, num_retries,
-                           user_data, resp)
+                           user_data, resp, headers)
 
         if self.class.should_retry?(e,
                                     method: method,
@@ -657,7 +657,7 @@ def self.maybe_gc_connection_managers
     end
 
     private def notify_request_end(context, duration, http_status, num_retries,
-                                   user_data, resp)
+                                   user_data, resp, headers)
       return if !Instrumentation.any_subscribers?(:request_end) &&
                 !Instrumentation.any_subscribers?(:request)
 
@@ -670,6 +670,7 @@ def self.maybe_gc_connection_managers
         request_id: context.request_id,
         user_data: user_data || {},
         response: resp,
+        request_header: headers,
         request_body: context.body
       )
       Stripe::Instrumentation.notify(:request_end, event)