catch NotImplementedError and map for older Ruby

stripe · Jan 13, 2025 · ca96e72 · ca96e72
1 parent 6c2f861
commit ca96e72
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/stripe/stripe_configuration.rb b/lib/stripe/stripe_configuration.rb
@@ -45,7 +45,12 @@ def self.client_init(config_opts)
       imported_options = USER_CONFIGURABLE_GLOBAL_OPTIONS - StripeClient::CLIENT_OPTIONS
       client_config = StripeConfiguration.setup do |instance|
         imported_options.each do |key|
-          instance.public_send("#{key}=", global_config.public_send(key)) if global_config.respond_to?(key)
+          begin
+            instance.public_send("#{key}=", global_config.public_send(key)) if global_config.respond_to?(key)
+          rescue NotImplementedError => e
+            # In Ruby <= 2.5, we can't set write_timeout on Net::HTTP, log an error and continue
+            Util.log_error("Failed to set #{key} on client configuration: #{e}")
+          end
         end
       end
       client_config.reverse_duplicate_merge(config_opts)

diff --git a/test/stripe/stripe_configuration_test.rb b/test/stripe/stripe_configuration_test.rb
@@ -99,7 +99,7 @@ class StripeConfigurationTest < Test::Unit::TestCase
 
     context "client_init" do
       setup do
-        @client_opts = StripeClient::CLIENT_OPTIONS.to_h { |k| [k, nil] }
+        @client_opts = Hash[StripeClient::CLIENT_OPTIONS.map { |k| [k, nil] }]
         @old_api_key = Stripe.api_key
         @old_stripe_account = Stripe.stripe_account
         @old_enable_telemetry = Stripe.instance_variable_get(:@enable_telemetry)