Use request_stripe_object for all requests #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…stripe_object_for_all_requests # Conflicts: # lib/stripe/resources/account.rb # lib/stripe/resources/apps/secret.rb # lib/stripe/resources/charge.rb # lib/stripe/resources/checkout/session.rb # lib/stripe/resources/credit_note.rb # lib/stripe/resources/customer.rb # lib/stripe/resources/dispute.rb # lib/stripe/resources/financial_connections/account.rb # lib/stripe/resources/identity/verification_session.rb # lib/stripe/resources/invoice.rb # lib/stripe/resources/issuing/authorization.rb # lib/stripe/resources/issuing/card.rb # lib/stripe/resources/issuing/dispute.rb # lib/stripe/resources/order.rb # lib/stripe/resources/payment_intent.rb # lib/stripe/resources/payment_link.rb # lib/stripe/resources/payment_method.rb # lib/stripe/resources/payout.rb # lib/stripe/resources/quote.rb # lib/stripe/resources/refund.rb # lib/stripe/resources/review.rb # lib/stripe/resources/setup_intent.rb # lib/stripe/resources/source.rb # lib/stripe/resources/subscription.rb # lib/stripe/resources/subscription_schedule.rb # lib/stripe/resources/terminal/reader.rb # lib/stripe/resources/test_helpers/test_clock.rb # lib/stripe/resources/topup.rb # lib/stripe/resources/transfer.rb # lib/stripe/resources/treasury/financial_account.rb # lib/stripe/resources/treasury/inbound_transfer.rb # lib/stripe/resources/treasury/outbound_payment.rb # lib/stripe/resources/treasury/outbound_transfer.rb
dcr-stripe
reviewed
Jun 10, 2022
There was a problem hiding this comment.
Overall I like the direction! Just a few questions. PTAL @pakrym-stripe
|
Note: The magic comments |
1 similar comment
|
Note: The magic comments |
|
r? @dcr-stripe |
remi-stripe
deleted the
pakrym/Use_request_stripe_object_for_all_requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using
request_stripe_objectfor all requests and removes special cased logic fromlistandsearch. The goal is to have the same logic accessible from custom methods as well as standard methods.