-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve request events instrumentation #1162
Improve request events instrumentation #1162
Conversation
88dd9b8
to
bd8d7ee
Compare
Hi @nguyhh, thanks so much for the contribution! Looks like there is a linting error, which you can fix by running Otherwise the implementation looks reasonable to me! I'm going to have @pakrym-stripe take a look as well, since he has more experience with stripe-ruby. |
380901a
to
70068a6
Compare
70068a6
to
89306d8
Compare
Hi! |
075e6f0
to
3440d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks so much for making those changes! This LGTM :)
What are you trying to accomplish?
This is an extension of the simple instrumentation callback what has been done previously in #870.
To create our own event logs of Stripe calls, we were missing certain informations when we subscribe to
Request
/RequestEnd
. The missing informations that we would like to have access to are:What approach did you choose and why?
We simply added the missing fields to the
RequestEndEvent
class.Please correct me if I am wrong, but here is my understanding on where to retrieve the missing informations.
context.body
would hold the request body informationresp.body
holds the response bodyresp.to_hash
seems to hold the hidden response headersexecute_request_with_rescues
method