Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: variable typo in README for instrumentation #1231

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix: variable typo in README for instrumentation #1231

merged 1 commit into from
Jun 20, 2023

Conversation

Justintime50
Copy link
Contributor

@Justintime50 Justintime50 commented Jun 12, 2023 •
edited
Loading

This PR fixes what I believe is a typo in the README example for instrumentation. The variable's name doesn't seem to match.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

anniel-stripe
anniel-stripe approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@anniel-stripe anniel-stripe merged commit d297fde into stripe:master Jun 20, 2023
@Justintime50 Justintime50 deleted the readme_instrumentation_typo branch June 20, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniel-stripe anniel-stripe anniel-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @CLAassistant @anniel-stripe