Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for dynamically referenced constants #1327

Merged
merged 6 commits into from
Feb 10, 2024

Conversation

helenye-stripe
Copy link
Contributor

@helenye-stripe helenye-stripe commented Feb 9, 2024

In preparation for running sorbet static checks

@helenye-stripe helenye-stripe force-pushed the helenye-dynamic-constant-ref-fixes branch from aee412a to 348b8ed Compare February 9, 2024 01:31
@helenye-stripe helenye-stripe requested review from a team and richardm-stripe and removed request for a team February 9, 2024 01:34
Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helenye-stripe helenye-stripe merged commit ce8d7ca into master Feb 10, 2024
13 checks passed
@helenye-stripe helenye-stripe deleted the helenye-dynamic-constant-ref-fixes branch July 16, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants