Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for APIResource.request #1435

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

helenye-stripe
Copy link
Contributor

@helenye-stripe helenye-stripe commented Jul 16, 2024

After releasing raw_request, this method should be deprecated. This TODO comment to remove in the next major has been here for ages, we should finally take action now that a more visible alternative exists. Doesn't change any behavior besides logging the message below.

Tested locally by calling the function, shows up with:

NOTE: Stripe::Account#request is deprecated; use Stripe.raw_request instead. It will be removed on or after 2024-07.

@helenye-stripe helenye-stripe requested review from a team and xavdid-stripe and removed request for a team July 16, 2024 17:14
@helenye-stripe helenye-stripe changed the title Deprecate regular request on API resource Deprecate APIResource.request Jul 16, 2024
@helenye-stripe helenye-stripe changed the title Deprecate APIResource.request Add deprecation warning for APIResource.request Jul 16, 2024
@helenye-stripe helenye-stripe merged commit ec36441 into master Jul 16, 2024
14 checks passed
@helenye-stripe helenye-stripe deleted the helenye-deprecate-request branch July 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants