Deprecate StripeObject#refresh_from
#328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #325, this deprecates the public visibility of `#refresh_from` (by renaming it). It also adds some deprecation infrastructure to produce warnings when it's used.
| @@ -181,5 +181,16 @@ def self.check_api_key!(key) | |||
| raise TypeError.new("api_key must be a string") unless key.is_a?(String) | |||
| key | |||
| end | |||
|
|
|||
| def self.warn_deprecated(name, options = {}) | |||
There was a problem hiding this comment.
Any chance we could use http://ruby-doc.org/stdlib-1.9.3/libdoc/rubygems/rdoc/Gem/Deprecate.html? I know it won't work for 1.8, but we may be able to work around that.
There was a problem hiding this comment.
Cool. Done in 1a96d7c. And amazingly I think it did work in 1.8 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #325, this deprecates the public visibility of
#refresh_from(by renaming it). It also adds some deprecationinfrastructure to produce warnings when it's used.