Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detach method for detaching sources from customers #589

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries @stan-stripe @will-stripe

  • Renames the Source.delete method to Source.detach. detach is more descriptive of what the method actually does (i.e. detaching the source object from its customer object, not actually deleting the source object).

  • Alias detach to delete with a deprecation warning to avoid a breaking change. We should remove the delete method in next major version.

@brandur-stripe
Copy link
Contributor

Thanks for the detailed description Olivier! +1 that #delete isn't sufficiently descriptive and even quite misleading.

@brandur-stripe brandur-stripe merged commit a0a9c7c into master Oct 11, 2017
@brandur-stripe brandur-stripe deleted the ob-detach-sources branch October 11, 2017 16:29
@brandur-stripe
Copy link
Contributor

Released as 3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants