Use duck typing to detect File-like objects

[ob-stripe]

r? @brandur-stripe
cc @stripe/api-libraries

Use duck typing to detect File-like objects rather than directly checking the class. This is the same strategy used by rest-client: https://github.com/rest-client/rest-client/blob/f450a0f086f1cd1049abbef2a2c66166a1a9ba71/lib/restclient/payload.rb#L55.

Thanks @kimroen for the suggestion!

Fixes #615.

[kimroen]

Nice! You don't need to require tempfile anymore now: https://github.com/stripe/stripe-ruby/pull/616/files#diff-df65def818cc84069ef28befc1fb1102L1

[coveralls]

Coverage remained the same at 91.808% when pulling 630c260 on ob-file-duck-typing into be8e4ff on master.

[ob-stripe]

Oops! Nice catch @kimroen, thanks!

[coveralls]

Coverage decreased (-0.005%) to 91.803% when pulling d946d7a on ob-file-duck-typing into be8e4ff on master.

[coveralls]

Coverage decreased (-0.005%) to 91.803% when pulling d946d7a on ob-file-duck-typing into be8e4ff on master.

[coveralls]

Coverage decreased (-0.005%) to 91.803% when pulling d946d7a on ob-file-duck-typing into be8e4ff on master.

[brandur-stripe]

This definitely seems better.

@ob-stripe Can you take a look at the Coveralls configuration here? A decrease of 0.005% in coverage probably shouldn't be a CI failure. My preference would be to allow something a lot more generous than that for the time being (1%?) — thoughts?

[ob-stripe]

Yep, agreed. I just set the threshold to 1% for all the libraries repos.

[coveralls]

Coverage decreased (-0.005%) to 91.803% when pulling b83a0e5 on ob-file-duck-typing into be8e4ff on master.

[coveralls]

Coverage decreased (-0.005%) to 91.803% when pulling b83a0e5 on ob-file-duck-typing into be8e4ff on master.

[coveralls]

Coverage decreased (-0.005%) to 91.803% when pulling b83a0e5 on ob-file-duck-typing into be8e4ff on master.

[ob-stripe]

Not sure why coveralls is posting 3 messages instead of 1, but the status check does take take the new threshold into account.

[brandur-stripe]

@ob-stripe Nice! Thanks.

BTW, I think there's a chance that we might be okay just disabling auto-comments completely given that they're a little noisy and that the coverage numbers are displayed down on the Coveralls status line anyway. We can cover that later though.

[ob-stripe]

Oh nice, I missed that the actual number was displayed in the status line. I've disabled Coverall comments for now, we can always re-enable them later if we think they're valuable.

[brandur-stripe]

Oh nice, I missed that the actual number was displayed in the status line. I've disabled Coverall comments for now, we can always re-enable them later if we think they're valuable.

+1. TY.

[brandur-stripe]

Released as 3.9.1.