Merge query parameters coming from path with params
argument
#647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If specifying both query parameters in a path/URL down to Faraday (e.g.,
/v1/invoices/upcoming?coupon=25OFF
) and query parameters in a hash(e.g.,
{ customer: "cus_123" }
), it will silently overwrite the onesin the path with the ones in the hash. This can cause problems where
some critical parameters are discarded and causes an error, as seen in
issue #646.
This patch modifies
#execute_request
so that before going out toFaraday we check whether the incoming path has query parameters. If it
does, we decode them and add them to our
query_params
hash so thatall parameters from either place are preserved.
Fixes #646.
r? @remi-stripe
cc @stripe/api-libraries