Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings for Terminal endpoints #690

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Conversation

daz-stripe
Copy link
Contributor

Bindings for Terminal endpoints

  • Connection Tokens
  • Locations
  • Readers

@daz-stripe
Copy link
Contributor Author

r? @remi-stripe
cc @stripe/api-libraries

Will hit rebuild once we release stripe-mocks! Still working on that

@rattrayalex-stripe rattrayalex-stripe removed their request for review September 17, 2018 21:55
@remi-stripe
Copy link
Contributor

Assigning to @ob-stripe to review those instead of me as I'm OOO today + traveling tomorrow

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Sep 17, 2018
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass after stripe-mock update.

@brandur-stripe
Copy link
Contributor

LGTM!

@brandur-stripe brandur-stripe merged commit 7b939cb into master Sep 24, 2018
@brandur-stripe brandur-stripe deleted the daz-terminal-bindings branch September 24, 2018 22:14
@brandur-stripe
Copy link
Contributor

Released as 3.28.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants