Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Subscription Schedules #739

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

remi-stripe
Copy link
Contributor

This adds two new resources: Subscription Schedule and Subscription Schedule Revision. The latter is nested under the former.

This should be ready even though we won't merge until all libraries are ready and stripe-mock supports those new endpoints publicly.

r? @ob-stripe
cc @stripe/api-libraries @alexander-stripe

@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedules branch 2 times, most recently from 2d43ceb to dd7a7fc Compare January 31, 2019 17:24
@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedules branch from dd7a7fc to 3fd97d7 Compare February 12, 2019 06:29
@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedules branch from 3fd97d7 to d784819 Compare February 12, 2019 06:38
@remi-stripe
Copy link
Contributor Author

@ob-stripe one more to review if possible, thank you!

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Feb 12, 2019
@remi-stripe remi-stripe merged commit 7af2826 into master Feb 12, 2019
@remi-stripe remi-stripe deleted the remi-add-subscription-schedules branch February 12, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants