Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase connection keep alive timeout to 30 seconds #836

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Increase connection keep alive timeout to 30 seconds #836

merged 1 commit into from
Aug 20, 2019

Commits on Aug 20, 2019

  1. Increase connection keep alive timeout to 30 seconds 

    One thing I forgot to look into was how long Ruby will hold a connection
open by default. It turns out that the language default is very low at
only two seconds. Here we increase it to 30 seconds, which is a more
reasonable default. I took this number from Go's `DefaultTransport`,
which seems to have been working pretty well so far.

I tested with a script that keeps a connection idle to Stripe for a long
period of time before issuing a new request and everything seems to be
working well.
    @brandur
    brandur committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    25bd677 View commit details
    Browse the repository at this point in the history