Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and typo in NestedResource #852

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

vasuadari
Copy link
Contributor

No description provided.

@brandur-stripe
Copy link
Contributor

Leaving this one for you @ob-stripe, since I think you wrote most of this. The new block indentation style is different, but not necessarily better — IMO, it'd be fair to ask for a revert on all of that.

@ob-stripe
Copy link
Contributor

Thanks for the contribution @vasuadari. Out of curiosity, what warnings does this fix?

@vasuadari
Copy link
Contributor Author

vasuadari commented Sep 21, 2019

@ob-stripe These are the warnings.

~/stripe-ruby/lib/stripe/api_operations/nested_resource.rb:34: warning: mismatched indentations at 'end' with 'do' at 30
~/stripe-ruby/lib/stripe/api_operations/nested_resource.rb:41: warning: mismatched indentations at 'end' with 'do' at 37
~/stripe-ruby/lib/stripe/api_operations/nested_resource.rb:48: warning: mismatched indentations at 'end' with 'do' at 44
~/stripe-ruby/lib/stripe/api_operations/nested_resource.rb:55: warning: mismatched indentations at 'end' with 'do' at 51
~/stripe-ruby/lib/stripe/api_operations/nested_resource.rb:62: warning: mismatched indentations at 'end' with 'do' at 58

@ob-stripe ob-stripe merged commit e61793e into stripe:master Sep 25, 2019
@ob-stripe
Copy link
Contributor

Just merged this. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants