Clean up test output by capturing $stderr when we expect warnings
#894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just noticed while running tests that we produce some accidental output because both of `Source#source_transactions` and `SubscriptionItem#usage_record_summaries` are considered deprecated and have warnings attached. Here we capture output to `$stderr` and assert on it from the test cases that call these deprecated methods -- this pattern is already well established elsewhere in the test suite.
ob-stripe
approved these changes
Jan 10, 2020
|
TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed while running tests that we produce some accidental
output because both of
Source#source_transactionsandSubscriptionItem#usage_record_summariesare considered deprecated andhave warnings attached.
Here we capture output to
$stderrand assert on it from the test casesthat call these deprecated methods -- this pattern is already well
established elsewhere in the test suite.
r? @ob-stripe
cc @stripe/api-libraries