Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce packed gem size #973

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Conversation

ybiquitous
Copy link
Contributor

This change aims to reduce the packed gem size by removing needless files from s.files.

Also, s.test_files is also removed because it is not defined in the gemspec reference.
(see https://guides.rubygems.org/specification-reference/)

  • Size changed: 215K -> 264K
  • Files changed: 221 files -> 120 files

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2021

CLA assistant check
All committers have signed the CLA.

This change aims to reduce the packed gem size by removing needless files from `s.files`.

Also, `s.test_files` is also removed because it is not defined in the gemspec reference.
(see <https://guides.rubygems.org/specification-reference/>)

- Size changed: 215K -> 264K
- Files changed: 221 files -> 120 files
@brandur-stripe
Copy link
Contributor

Thanks Masafumi!

Also, s.test_files is also removed because it is not defined in the gemspec reference.
(see https://guides.rubygems.org/specification-reference/)

That's a weird one. I was wondering if we just made up that property, but it's definitely right there in the source code: https://github.com/ruby/ruby/blob/e0bd293855d0062a895233e7735b9c65db7c5500/lib/rubygems/specification.rb#L697-L707 and isn't listed in that file as deprecated or anything. Oh well, we don't really use it for anything anyway.

@brandur-stripe brandur-stripe merged commit ec31858 into stripe:master Apr 5, 2021
@ybiquitous ybiquitous deleted the reduce-gem-size branch April 5, 2021 19:17
@ybiquitous
Copy link
Contributor Author

Umm..., I'm not sure why test_files has been removed from the reference... 🤔

Oh well, we don't really use it for anything anyway.

Yes, there are no problems even if removing it.

Thanks for the merge! 😄

@brandur-stripe
Copy link
Contributor

Umm..., I'm not sure why test_files has been removed from the reference... 🤔

Haha yes very mysterious!

Released as 5.32.0.

@ybiquitous
Copy link
Contributor Author

Thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants