Implemented #respond_to? #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the correct way is to override |
|
You're right. Didnt know about respond_to_missing :) |
| @@ -102,6 +102,16 @@ def each(&blk) | |||
| @values.each(&blk) | |||
| end | |||
|
|
|||
| if RUBY_VERSION < '1.9.2' | |||
| def respond_to?(symbol) | |||
| @values.has_key(symbol) || super | |||
|
Sorry about the delay here! Left a few notes. Would you mind moving |
|
On second thought, I went ahead and did it for you to finish it out! I saved your commits, so you will see them on the master branch. Thanks for the submission! If you have any questions, feel free to send an email to support@stripe.com. |
|
Cool, thanks;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #92 and #55