Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between documentation and types file when calling createSetupIntent #591

Closed
Laulhus opened this issue Dec 13, 2023 · 2 comments
Closed
Assignees

Comments

@Laulhus
Copy link

Laulhus commented Dec 13, 2023

Describe the bug
When calling function createSetupIntent, params ask to pass a property customerId with a string containing the ID of the customer we want to create the setup intent for. If passed like this, property in the API resolves to nullish and therefore, doesn't attach a provided payment method to the customer when calling other functions. This is because the actual name of the property in Stripe API is customer, as it says in the documentation.

To Reproduce
Steps to reproduce the behavior:

  1. Create a setup intent using the SDK passing a property customerId
  2. Check the logs in your Stripe dashboard and the setup intent object created will have property customer:null
  3. Create a setup intent using the SDK passing a property customer
  4. Check the logs in your Stripe dashboard and the setup intent object created will have property customer: {{string provided}}

Expected behavior
When creating a setup intent passing a customer ID, the object that returns should contain this string in the property customer

Screenshots
With property customerId:

Captura de pantalla 2023-12-13 a las 11 58 52

Captura de pantalla 2023-12-13 a las 12 03 07

Stripe Terminal React Native SDK version

With property customer:
Captura de pantalla 2023-12-13 a las 12 04 04

Captura de pantalla 2023-12-13 a las 12 00 35

Stripe Terminal React Native Version

  • ^0.0.1-beta.14
@nazli-stripe
Copy link
Collaborator

Fixed in #766

@nazli-stripe
Copy link
Collaborator

This is now publicly available with the release of beta.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants