Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laulhus/fix create setup intent params #592

Closed
wants to merge 2 commits into from
Closed

Laulhus/fix create setup intent params #592

wants to merge 2 commits into from

Conversation

Laulhus
Copy link

@Laulhus Laulhus commented Dec 13, 2023 •
edited
Loading

Summary

Changed property name customerId to customer in CreateSetupIntentParams and SetupIntentScreen

Motivation

Fixing mismatch between types file and published documentation.
Issue: #591 (comment)

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billfinn-stripe billfinn-stripe Awaiting requested review from billfinn-stripe billfinn-stripe is a code owner

@bric-stripe bric-stripe Awaiting requested review from bric-stripe bric-stripe is a code owner

@nazli-stripe nazli-stripe Awaiting requested review from nazli-stripe nazli-stripe is a code owner

@chr-stripe chr-stripe Awaiting requested review from chr-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Laulhus @CLAassistant @nazli-stripe