Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] StripeTerminalReactNativeModule: Fix setting customer #401

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

billfinn-stripe
Copy link
Collaborator

Summary

Fix typo with passing params from RN to Android.

Motivation

Fixes #400.

Testing

  • I tested this manually
diff --git a/dev-app/src/screens/CollectCardPaymentScreen.tsx b/dev-app/src/screens/CollectCardPaymentScreen.tsx
index 7ca6c9a..0a7a3a0 100644
--- a/dev-app/src/screens/CollectCardPaymentScreen.tsx
+++ b/dev-app/src/screens/CollectCardPaymentScreen.tsx
@@ -153,6 +153,7 @@ export default function CollectCardPaymentScreen() {
       const response = await createPaymentIntent({
         amount: Number(inputValues.amount),
         currency: inputValues.currency,
+        customer: '<REDACTED>',
         paymentMethodTypes: paymentMethods,
         setupFutureUsage: enableInterac ? undefined : 'off_session',
         onBehalfOf: inputValues.connectedAccountId,

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

chr-stripe
chr-stripe previously approved these changes Oct 17, 2022
Copy link
Contributor

@chr-stripe chr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/should we unit test this?

@billfinn-stripe
Copy link
Collaborator Author

Can/should we unit test this?

I responded in DM, but also responding here. We currently don't have unit tests for StripeTerminalReactNativeModule. I'm not sure what the ROI would be. For now, I'm mostly comfortable requiring us to manually test changes to StripeTerminalReactNativeModule.

@billfinn-stripe billfinn-stripe merged commit f566307 into main Oct 17, 2022
@billfinn-stripe billfinn-stripe deleted the billfinn/fix-customer branch October 17, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android | Issue while getting paymentIntent data from stripe.
4 participants